Skip to content

gh-138050: Global cooling: use cold flag instead of warm flag in MAKE_WARM#143827

Merged
markshannon merged 1 commit into
python:mainfrom
cocolato:feat/global_cooling
Jan 14, 2026
Merged

gh-138050: Global cooling: use cold flag instead of warm flag in MAKE_WARM#143827
markshannon merged 1 commit into
python:mainfrom
cocolato:feat/global_cooling

Conversation

@cocolato

@cocolato cocolato commented Jan 14, 2026

Copy link
Copy Markdown
Member

@markshannon markshannon changed the title gh-138050: Global cooling: use cold flag instead of wram flag in MAKE_WARM gh-138050: Global cooling: use cold flag instead of warm flag in MAKE_WARM Jan 14, 2026
@markshannon

Copy link
Copy Markdown
Member

On Aarch64, this changes the MAKE_WARM stencil from:

  mov     w8, #0x1
  strb    w8, [x20, #0x24]

to

  strb    wzr, [x20, #0x24]

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@markshannon markshannon merged commit 94dbce1 into python:main Jan 14, 2026
93 of 95 checks passed
@cocolato cocolato deleted the feat/global_cooling branch January 20, 2026 14:12
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants